Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to classmap #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switched to classmap #9

wants to merge 1 commit into from

Conversation

nrbrook
Copy link

@nrbrook nrbrook commented Dec 20, 2013

I have switched to classmap by changing the composer.json file and removing the now unnecessary requires in Mixpanel.php. I think this works...needs some testing. This was in response to #8

@jbwyme
Copy link
Contributor

jbwyme commented Jan 29, 2014

Thanks for the pull request. My main concern is that I want people who are using php < 5.3 to be able to use this library. Correct me if I'm wrong, but I believe that by switching to classmap it will require namespacing

@nrbrook
Copy link
Author

nrbrook commented Jan 29, 2014

Composer requires php >5.3.2 so it doesn't matter. Just leave in the requires if you want it to be compatible with php < 5.3.

@nrbrook
Copy link
Author

nrbrook commented Jan 29, 2014

Classmap is used to auto load libraries that do not comply with psr-0, so you don't need to use namespaces. As you can see in my pull request it doesn't add namespaces.

@jbwyme
Copy link
Contributor

jbwyme commented Jan 29, 2014

Oh ok great I'll do some testing with it and see about getting it merged. Thanks!

@jbwyme jbwyme force-pushed the master branch 3 times, most recently from d56b9db to b03cf69 Compare July 8, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants