Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor corrections to Autocapture docs #1758

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

tdumitrescu
Copy link
Member

No description provided.

@tdumitrescu tdumitrescu requested a review from abraibrai February 5, 2025 00:19
@tdumitrescu tdumitrescu requested a review from a team as a code owner February 5, 2025 00:19
@tdumitrescu tdumitrescu requested review from argenisf and removed request for a team February 5, 2025 00:19
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 0:22am

| `$host` | The hostname of the webpage where the event was triggered (e.g., `example.com`). |
| `$pathname` | The path portion of the URL where the event occurred (e.g., `/checkout`). |
| `$elements` | A list of elements that were involved in the event, useful for understanding event context. |
| `$elements` | A list of elements that were involved in the event, useful for understanding element context. |
| `$target` | The specific HTML element that triggered the event (e.g., a button or link). |
| `$el_attr__href` | The href attribute of the target element if it is a link (`<a>` tag). |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abraibrai these are the raw prop names, but do the docs give the text anywhere of how these actually appear in the UI? e.g. this one would be

Suggested change
| `$el_attr__href` | The href attribute of the target element if it is a link (`<a>` tag). |
| `[Auto] Link target` | The href attribute of the target element if it is a link (`<a>` tag). |

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanups -- and good call on the UI names, can do those later today

@abraibrai abraibrai merged commit 9a90e93 into main Feb 5, 2025
8 checks passed
@abraibrai abraibrai deleted the autocapture-corrections branch February 5, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants