This repository was archived by the owner on Aug 31, 2019. It is now read-only.
Lm/toasted errors #100
Open
Lm/toasted errors #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Malinowski <[email protected]>
Add callback option to dispatcher for load_file, only one so far, that is for if JSON.parse() errors out due to syntax error. A better way to do this is to write a Toast component, and send TOAST_MESSAGES through vuex whenever an error happens, but this works for testing now. Related to #97 Signed-off-by: Luke Malinowski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add toasted error display for when JSON.parse fails.
Alternative is to make a Toast component, one does exist https://github.com/ktsn/vuex-toast, but it doesn't look super clean, and we can write our own properly namespaced one for our store in around 50 lines