Skip to content

Conversation

@uruwhy
Copy link
Contributor

@uruwhy uruwhy commented Oct 30, 2025

Description

  • properly close FTP and TCP contacts to address associated warnings in unit tests
  • make FTP unit tests able to remove non-empty FTP directory, and use test directory name (fixes edge case where FTP unit test fails when users have previously used the FTP contact)
  • set the pyasn1 version to 0.5.x to address pyasn1-related warnings in unit tests
  • remove event_loop fixtures in unit tests to address related warnings
  • update mock return setup in data svc test to address warnings

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran unit tests locally
Ran manx agent with TCP contact to verify functionality still intact, verified server closed with dead and live manx sessions
Ran sandcat agent with FTP contact to verify functionality still intact

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@uruwhy uruwhy marked this pull request as ready for review December 9, 2025 14:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@uruwhy uruwhy requested a review from clenk December 9, 2025 16:29
@uruwhy uruwhy self-assigned this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants