Skip to content

Conversation

tecoholic
Copy link
Contributor

What are the relevant tickets?

Following up on #590

Description (What does it do?)

When matching the users between openedx and canvas, we use the "login_id" instead of the "email" in Canvas's response, as matching on email doesn't seem to be working in production.

Screenshots (if appropriate):

N/A

How can this be tested?

Following the testing instructions in #500

Additional Context

  • We also add a log.debug statement to log the full Canvas response. We decided to do this for short-term debugging as we don't have any visibility into Canvas's logs.

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a595016). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage        ?   85.62%           
=======================================
  Files           ?       85           
  Lines           ?     3081           
  Branches        ?        4           
=======================================
  Hits            ?     2638           
  Misses          ?      443           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@blarghmatey blarghmatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just bump the patch version as well so that the publishing goes out properly?

@tecoholic
Copy link
Contributor Author

@blarghmatey I updated the patch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants