Skip to content

update spinner usage #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

update spinner usage #2301

merged 1 commit into from
Jun 16, 2025

Conversation

ChristopherChudzicki
Copy link
Contributor

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/7361

Description (What does it do?)

Updates button spinner as changed in mitodl/smoot-design#127

Screenshots (if appropriate):

learn.mov

How can this be tested?

As a logged in user,

  1. Visit http://learn.odl.local:8062/onboarding
  2. In dev console, throttle your network (or turn it off completely)
  3. make a change and hit "next"
  4. enjoy the spinner

@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Jun 10, 2025
@jonkafton jonkafton self-assigned this Jun 12, 2025
@ChristopherChudzicki
Copy link
Contributor Author

@jonkafton Not sure if you've looked at this yet, but the smoot version is updated to a published version now.

Copy link
Contributor

@jonkafton jonkafton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristopherChudzicki ChristopherChudzicki merged commit 5efc1fa into main Jun 16, 2025
13 checks passed
@ChristopherChudzicki ChristopherChudzicki deleted the cc/spinner-fix branch June 16, 2025 14:43
This was referenced Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review An open Pull Request that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants