Skip to content

Conversation

@annagav
Copy link
Contributor

@annagav annagav commented Nov 7, 2025

What are the relevant tickets?

N/A

Description (What does it do?)

The title of DEDP has been updated

This is used in bulk user data update, which filters users only in the program for update.

How can this be tested?

Nothing should break

@gemini-code-assist
Copy link

Summary of Changes

Hello @annagav, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a minor but important data correction, updating the official title for the DEDP program. This ensures that all systems relying on this constant, particularly those involved in bulk user data updates, accurately identify and filter users associated with the program.

Highlights

  • DEDP Program Title Update: The constant DEDP_PROGRAM_TITLE has been updated to reflect the correct program name, changing from 'Data, Economics, and Development Policy' to 'Data, Economics, and Design of Policy'.
  • Impact on User Data Updates: This title is used in the bulk user data update process to accurately filter users within the program.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the title of the DEDP program, which is stored as a constant. The change is straightforward and reflects an update to the program's name. My review includes a suggestion to add a comment highlighting the fragility of identifying programs by their title string, and recommends considering a more robust identification method in the future to improve maintainability.

"""

DEDP_PROGRAM_TITLE = "Data, Economics, and Development Policy"
DEDP_PROGRAM_TITLE = "Data, Economics, and Design of Policy"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the program title as a string to identify a specific program is fragile. If the title changes in the database again, this logic will break. It would be more robust to identify this program using a more stable identifier, like a database ID, a slug, or a dedicated boolean field on the Program model. Since this is a wider change, it could be addressed in a separate ticket, but it's worth noting for future maintainability. I've added a comment to highlight this.

Suggested change
DEDP_PROGRAM_TITLE = "Data, Economics, and Design of Policy"
# This is used to identify the DEDP program by its title. This is fragile and may break if the program title is changed in the database.
DEDP_PROGRAM_TITLE = "Data, Economics, and Design of Policy"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants