Raise OSError for UDP server startup failures - #323
Open
Sonike wants to merge 1 commit into
Open
Conversation
mhils
reviewed
Aug 23, 2026
| } | ||
|
|
||
| /// Convert I/O errors wrapped by anyhow into Python OSErrors, preserving errno. | ||
| pub fn anyhow_to_pyerr(error: anyhow::Error) -> PyErr { |
Member
There was a problem hiding this comment.
Can we rename this to ioerror_to_oserror or something like this?
Author
There was a problem hiding this comment.
Agreed — ioerror_to_oserror is clearer. I'll rename it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::io::Errors wrapped byanyhowinto PythonOSErrors at the UDP and WireGuard server boundariesEADDRINUSEand show its existing actionable port suggestionFixes mitmproxy/mitmproxy#7650.
Test plan
cargo fmt --all --checkcargo clippy -p mitmproxy_rs --all-targets -- -D warningscargo test -p mitmproxy_rsThis change was prepared with Codex assistance and verified locally.