Skip to content

[DO NOT MERGE] Modern solution #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Modern solution #14

wants to merge 10 commits into from

Conversation

smatsuodev
Copy link

No description provided.

@smatsuodev smatsuodev changed the title Modern solution [DO NOT MERGE] Modern solution Jun 19, 2024
import javax.inject.Singleton

@Singleton
class GithubRepoCacheRepository @Inject constructor(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

↓を読むとData層にはどういう処理をどこに書くべきかがわかると思いました
https://developer.android.com/topic/architecture/data-layer

命名などいろんな流儀はあると思いますが、一旦はAndroid公式ドキュメントにある実質デファクトな作り方を理解する、という意味でこのドキュメントに沿った作り方で作るのが良いかと思います

@smatsuodev smatsuodev requested a review from Yamada-Ika July 4, 2024 03:50
@smatsuodev smatsuodev self-assigned this Jul 9, 2024
@caad1229 caad1229 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants