Added support for Laravel Migrations & Reminders #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is excellent. Will test it out when I get home. |
|
I found a bug with the getRan() method. It should work better now. |
|
I've added support for password reminders as well. Let me know if you'd prefer that in a seperate PR. |
neon64
changed the title
Added `@dev` within version constraint so that the rest of a projects dependencies can be stable.
|
👍 |
|
There's some comments in some of the code that can be removed - and please write tests for the new features. |
|
@neon64 ping! |
|
I've been without stable internet for a couple of days but I'll try to get those fixes done asap. |
|
What comments did you want removed? I could only find the |
|
Sorry. I forgot to merge new changes from upstream. The tests are fine now |
Also began work on tests for Migrations and Reminders
…rationRepository`
|
👍 |
…PresenceVerifier` Needed if the presence verifier is overriden again by the user. Used to go like this: - validator factory is resolved when $app['validator'] is accessed (in order to call $validator->resolver($foo) ) - validation factory accesses the `validation.presence` verifier - the presence verifier is accessed, thus the entity manager is requested - this prompts a connection to the database on every instantiation of the application Now the connection won't be resolved until the verifier is actually used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine automatically updates the database schema to represent the entities in your application, thus rendering most of the use-cases for Laravel's migrations useless, however Laravel's migrations can still be useful for migrating other stuff, such as data stored on the filesystem.
What's Changed
This pull request adds support for Laravel migrations, using Doctrine for the DB interaction. It adds a new Entity:
Migration, that is automatically included into themetadataconfig. It also adds a new implementation ofMigrationRepositoryInterfacethat uses Doctrine instead of Laravel's DB.I've also added support for Laravel's password reminders.
Caveats:
Migrationentity cannot be removed (perhaps I should add a config option)It'd be great to know what you think about this, and if it is a good fit for your package.