Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for l18n hero images #246

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tassoman
Copy link

@tassoman tassoman commented Oct 5, 2024

We have ability to show translated images to user reading in their local language

@kakkokari-gtyih
Copy link
Collaborator

We have ability to show translated images to user reading in their local language

Actually, no

@tassoman
Copy link
Author

tassoman commented Oct 5, 2024

@kakkokari-gtyih you mean rejected? 🫤

@kakkokari-gtyih
Copy link
Collaborator

kakkokari-gtyih commented Oct 5, 2024

You uploaded just images at the time i commented that, so I thought you think we've already implemented the image localization feature code

@tassoman
Copy link
Author

tassoman commented Oct 5, 2024

Sorry for misunderstanding!
I made this simple PR but, an optimized one, should include files only if available, then fallback into original file.
So that, adding images is an optional while adding languages. I'm sorry I can't code this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants