Extract Log_trap abstraction and cleanup log handling #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfe
force-pushed
the
refactor-log-capturing
branch
from
6612916 to
e1a05c3
Compare
It's relatively common to use `__FILE__` as a test name, in which case it's helpful for these characters to be escaped less noisily.
craigfe
force-pushed
the
refactor-log-capturing
branch
from
e1a05c3 to
b30882a
Compare
Ngoguey42
reviewed
May 4, 2021
Comment on lines
+3
to
+5
| module Fun = struct | ||
| let id x = x | ||
| end |
There was a problem hiding this comment.
What's wrong with the one from Stdlib? :)
There was a problem hiding this comment.
It doesn't exist pre-4.08, sadly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out a
Log_trapcomponent for capturing test logs in files.This is another chunk of refactoring extracted from #294, which requires some more complicated redirection logic.