Skip to content

Fix Eigen incompatible matrix sizes error (only shown in debug build) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Eigen incompatible matrix sizes error (only shown in debug build) #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57dec2a
Update sparse_gp.cpp
martinbrehm Sep 27, 2024
35a8a67
Update normalized_dot_product.cpp
martinbrehm Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/flare_pp/bffs/sparse_gp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ void SparseGP ::update_matrices_QR() {
.triangularView<Eigen::Upper>()
.solve(Kuu_eye);
R_inv_diag = R_inv.diagonal();
alpha = R_inv * Q_b;
alpha = R_inv * Q_b.head( R_inv.cols() );
Sigma = R_inv * R_inv.transpose();
}

Expand Down
15 changes: 9 additions & 6 deletions src/flare_pp/kernels/normalized_dot_product.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@ Eigen::MatrixXd NormalizedDotProduct ::envs_envs(const ClusterDescriptor &envs1,
// Why not do envs1.descriptors[s] / envs1.descriptor_norms[s]
// and then multiply them to get norm_dot matrix directly??
// Compute dot products. (Should be done in parallel with MKL.)
Eigen::MatrixXd dot_vals =
envs1.descriptors[s] * envs2.descriptors[s].transpose();
Eigen::MatrixXd dot_vals;
if ((envs1.descriptors[s].rows() != 0) && (envs1.descriptors[s].cols() != 0))
dot_vals = envs1.descriptors[s] * envs2.descriptors[s].transpose();

// Compute kernels.
int n_sparse_1 = envs1.n_clusters_by_type[s];
Expand Down Expand Up @@ -137,10 +138,12 @@ Eigen::MatrixXd NormalizedDotProduct ::envs_struc(const ClusterDescriptor &envs,

for (int s = 0; s < n_types; s++) {
// Compute dot products. (Should be done in parallel with MKL.)
Eigen::MatrixXd dot_vals =
envs.descriptors[s] * struc.descriptors[s].transpose();
Eigen::MatrixXd force_dot =
envs.descriptors[s] * struc.descriptor_force_dervs[s].transpose();
Eigen::MatrixXd dot_vals;
Eigen::MatrixXd force_dot;
if ((envs.descriptors[s].rows() != 0) && (envs.descriptors[s].cols() != 0)) {
dot_vals = envs.descriptors[s] * struc.descriptors[s].transpose();
force_dot = envs.descriptors[s] * struc.descriptor_force_dervs[s].transpose();
}

Eigen::VectorXd struc_force_dot = struc.descriptor_force_dots[s];

Expand Down