Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @minyoungg . Thanks for the great work. I'd like to point out one issue which may result in CUDA device issue.
Your install requirements are
in
setup.py
.However, in
torchpq-0.3.0.1
, there is a bug that they always create new tensors oncuda:0
, it is a problem for those who have multiple devices. The author oftorchpq
fixed the bug since version 0.3.0.3 (see link).So I suggest you update the install requirements in
setup.py
toBest,
Chris
:)