Conversation
iljakuklic
requested review from
TheQuantumPhysicist,
erubboli and
muursh
as code owners
|
|
||
| // Test the interpreter on all 4-byte combinations of non-trivial opcodes. | ||
| #[test] | ||
| //#[ignore = "This test is too expensive to run by default"] |
There was a problem hiding this comment.
Did you mean to comment the ignore?
There was a problem hiding this comment.
Not sure. It runs pretty quickly in release mode, but under debug, I will have to measure.
There was a problem hiding this comment.
Running this test with debug build takes 147 seconds on my laptop.
There was a problem hiding this comment.
What do we aim for in these tests? Are tests that run a long-ish time under debug acceptable or do we want to disable them by default (make opt-in)?
There was a problem hiding this comment.
147s is okay for me but is probably approaching the limit of "I'm getting bored waiting for this"-ness so maybe making them opt-in is a good idea. If someone touches the script stuff then they know to run them anyway so we're probably safe.
There was a problem hiding this comment.
In release mode, it is about 5s on my laptop btw
iljakuklic
force-pushed
the
script-exhaustive-tests
branch
from
f7f742e to
e6aca48
Compare
iljakuklic
force-pushed
the
script-exhaustive-tests
branch
from
e6aca48 to
34f9b90
Compare
iljakuklic
force-pushed
the
script-exhaustive-tests
branch
from
34f9b90 to
53a235e
Compare
iljakuklic
force-pushed
the
script-exhaustive-tests
branch
from
53a235e to
600ea45
Compare
4 participants
No description provided.