Skip to content

fix: set default false for statObject's deletemarker #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiuker wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Open

fix: set default false for statObject's deletemarker #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2684417
fix: set default false for statObject's deletemarker
Aug 6, 2026
7cf5afe
Merge branch 'minio:main' into fix-set-default-false-for-statObject's…
jiuker Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/miniocpp/response.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ struct StatObjectResponse : public Response {
RetentionMode retention_mode;
utils::UtcTime retention_retain_until_date;
LegalHold legal_hold;
bool delete_marker;
bool delete_marker = false;
utils::Multimap user_metadata;

StatObjectResponse() = default;
Expand Down Expand Up @@ -284,7 +284,7 @@ MINIO_S3_DERIVE_FROM_PUT_OBJECT_RESPONSE(UploadObjectResponse)
struct DeletedObject : public Response {
std::string name;
std::string version_id;
bool delete_marker;
bool delete_marker = false;
std::string delete_marker_version_id;

DeletedObject() = default;
Expand Down
3 changes: 3 additions & 0 deletions tests/tests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ class Tests {
"StatObject(): expected: " + std::to_string(data.length()) +
"; got: " + std::to_string(resp->size));
}
if (resp->delete_marker) {
throw std::runtime_error("StatObject(): expected: false; got: true");
}
RemoveObject(bucket_name_, object_name);
} catch (const std::runtime_error&) {
RemoveObject(bucket_name_, object_name);
Expand Down
Loading