-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added API Endpoint for Validating Connection Parameters #10446
base: main
Are you sure you want to change the base?
Conversation
@@ -112,6 +112,48 @@ def post(self, handler_name): | |||
) | |||
|
|||
|
|||
@ns_conf.route('/<handler_name>/test_connection') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we choose a different path name as health
or status
? WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. Would connection/status
be better? Just to avoid any confusion between the status of the connection and the handler itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of something to sound more like action instead of using a verb in path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, shall I make it handler/status
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please also add docs
Description
This PR adds an API endpoint for the checking the validity of integration connection parameters.
Fixes https://linear.app/mindsdb/issue/BE-624/test-data-connection-details
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: