Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Cast orderby to numerical, check TS length before finalizing split #54

Merged
merged 3 commits into from
Apr 30, 2024
Merged

[Fix] Cast orderby to numerical, check TS length before finalizing split #54

merged 3 commits into from
Apr 30, 2024

Conversation

paxcema
Copy link
Contributor

@paxcema paxcema commented Apr 30, 2024

Minor fixes motivated by mindsdb#8358:

  • Check split lengths before admitting split as valid in forecast scenarios
  • Cast order by column to numerical in forecast scenarios

@paxcema paxcema requested a review from dusvyat April 30, 2024 13:50
dusvyat
dusvyat approved these changes Apr 30, 2024
View reviewed changes
@paxcema paxcema merged commit e33b27c into staging Apr 30, 2024
10 checks passed
@paxcema paxcema mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusvyat dusvyat dusvyat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paxcema @dusvyat