Skip to content

[WIP] Migration from Cargo to Bazel #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

[WIP] Migration from Cargo to Bazel #45

wants to merge 19 commits into from

Conversation

tudny
Copy link
Collaborator

@tudny tudny commented Mar 24, 2023 •
edited
Loading

Solves #46

@tudny tudny linked an issue Mar 24, 2023 that may be closed by this pull request
Migrate to Bazel #46
Closed
8 tasks
@tudny tudny changed the title Migration from Cargo to Bazel [WIP] Migration from Cargo to Bazel Mar 24, 2023
@tudny tudny marked this pull request as draft March 24, 2023 14:57
@tudny
Copy link
Collaborator Author

tudny commented Mar 30, 2023

This sometimes builds and runs flawless. Unfortunately, khronos_api uses build.rs to generate a file in khronos_api_build_script.out_dir which consists of an array of include_bytes macros with absolute path. Due to the Bazel build system, somehow those files do not exist.

E.g., "/home/tudny/.cache/bazel/_bazel_tudny/435ff6245ae9e88ea932b4c85c125c63/sandbox/linux-sandbox/149/execroot/__main__/bazel-out/k8-opt-exec-2B5CBBC6/bin/external/crate_index__khronos_api-3.1.0/khronos_api_build_script_.runfiles/crate_index__khronos_api-3.1.0/api_webgl/extensions/OES_texture_float/extension.xml, but /149/ sandbox does not exist after the build, so the path is invalid.

@tudny tudny added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed security Security issues dependencies Pull requests that update a dependency file labels Apr 13, 2023
@tudny tudny mentioned this pull request Apr 13, 2023
Closed
@tudny
Copy link
Collaborator Author

tudny commented Apr 25, 2023

I fixed the khronos_api issue according to this PR: rust-windowing/gl-rs#536

@tudny
Copy link
Collaborator Author

tudny commented Apr 29, 2023

I guess we will not merge it, but I would like to keep this branch.
It is a great testing repo for my bachelor's thesis project.
http://github.com/zpp-This-is-fine/

@tudny tudny closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed security Security issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Bazel
1 participant
@tudny