Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data race when accessing field_ when retrieving #39151

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: data race when accessing field_ when retrieving #39151

merged 1 commit into from
Jan 13, 2025

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 10, 2025

issue: #39148

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 10, 2025
@chyezh chyezh mentioned this pull request Jan 10, 2025
Merged
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.11%. Comparing base (826b726) to head (5bcf1b2).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39151      +/-   ##
==========================================
- Coverage   81.16%   81.11%   -0.05%     
==========================================
  Files        1395     1395              
  Lines      197277   197280       +3     
==========================================
- Hits       160124   160033      -91     
- Misses      31539    31616      +77     
- Partials     5614     5631      +17
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.65% <0.00%> (+<0.01%) ⬆️
Go 83.04% <ø> (-0.06%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 83.91% <0.00%> (-0.25%) ⬇️

... and 27 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jan 10, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 10, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 5f94954 into milvus-io:master Jan 13, 2025
18 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jan 13, 2025
@chyezh
fix: data race when accessing field_ when retrieving (#39152)
0aa592b 
issue: #39148
pr: #39151

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh deleted the fix_data_race_for_field_access branch January 13, 2025 05:44
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
@chyezh @gifi-siby
fix: data race when accessing field_ when retrieving (milvus-io#39151)
aae3d3c 
issue: milvus-io#39148

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@jaime0815 jaime0815

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chyezh @sre-ci-robot @jaime0815