Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HierarchyPager used instead of FlatPager to adhere bulk insert failure on using Azure buckets #39149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gifi-siby
Copy link

Related task: #39135

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 10, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gifi-siby
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 10, 2025

@gifi-siby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@gifi-siby

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@gifi-siby gifi-siby force-pushed the 39134_bulk_insert_Azure branch 2 times, most recently from 2f9db68 to 3f0cbff Compare January 10, 2025 06:02
@congqixia congqixia changed the title [fix]: HierarchyPager used instead of FlatPager to adhere bulk insert failure on using Azure buckets fix: HierarchyPager used instead of FlatPager to adhere bulk insert failure on using Azure buckets Jan 10, 2025
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@gifi-siby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@gifi-siby go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@gifi-siby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@gifi-siby gifi-siby force-pushed the 39134_bulk_insert_Azure branch from 3f0cbff to 9685b6c Compare January 10, 2025 07:36
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (4355b48) to head (9685b6c).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #39149   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         296      296           
  Lines       26633    26633           
=======================================
  Hits        18548    18548           
  Misses       8085     8085           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.64% <ø> (ø)
Go ∅ <ø> (∅)

Copy link
Contributor

mergify bot commented Jan 10, 2025

@gifi-siby go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@gifi-siby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@gifi-siby
Copy link
Author

/run-cpu-e2e

@gifi-siby
Copy link
Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 10, 2025

@gifi-siby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug needs-dco DCO is missing in this pull request. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants