fix: fix chunk cache madvise when sparse raw data is mmaped #39145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Buqian Zheng <[email protected]>
mergify
bot
added
dco-passed
|
@zhengbuqian Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
|
@zhengbuqian E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
rerun go-unit-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #39145 +/- ##
===========================================
+ Coverage 69.64% 81.13% +11.49%
===========================================
Files 296 1395 +1099
Lines 26633 197296 +170663
===========================================
+ Hits 18548 160077 +141529
- Misses 8085 31585 +23500
- Partials 0 5634 +5634
|
|
issue: #39158 |
mergify
bot
added
ci-passed
and removed
do-not-merge/missing-related-issue
ci-passed
labels
sre-ci-robot
pushed a commit
that referenced
this pull request
Jan 10, 2025
…9146) instead of marking as not supported, ChunkedSparseFloatColumn::DataByteSize can simply use the impl of super class. pr: #39145 issue: #39158 Signed-off-by: Buqian Zheng <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gifi-siby
pushed a commit
to gifi-siby/milvus
that referenced
this pull request
Jan 16, 2025
…o#39145) instead of marking as not supported, `ChunkedSparseFloatColumn::DataByteSize` can simply use the impl of super class. issue: milvus-io#39158 Signed-off-by: Buqian Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of marking as not supported,
ChunkedSparseFloatColumn::DataByteSizecan simply use the impl of super class.issue: #39158