Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add schema update time verification for insert and upsert to use cache #39096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: Add schema update time verification for insert and upsert to use cache #39096

wants to merge 1 commit into from
+164 −37

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Jan 8, 2025

enhance: Add schema update time verification for insert and upsert to use cache
issue: #39093

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/M Denotes a PR that changes 30-99 lines. labels Jan 8, 2025
@JsDove JsDove mentioned this pull request Jan 8, 2025
Open
1 task
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JsDove
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 8, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 8, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (461c376) to head (94bc70a).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #39096   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         296      296           
  Lines       26633    26633           
=======================================
  Hits        18548    18548           
  Misses       8085     8085
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.64% <ø> (ø)
Go ∅ <ø> (∅)

@JsDove JsDove force-pushed the schemacache branch 2 times, most recently from e9ddceb to 3185bf6 Compare January 9, 2025 02:30
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jan 9, 2025
@JsDove JsDove force-pushed the schemacache branch 3 times, most recently from 580fb0c to f69e405 Compare January 9, 2025 05:52
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove JsDove force-pushed the schemacache branch 4 times, most recently from 59713cc to 61d41bc Compare January 9, 2025 11:23
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

@JsDove cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Jan 9, 2025

rerun cpp-unit-test

@JsDove
Copy link
Contributor Author

JsDove commented Jan 9, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 9, 2025
@JsDove
Add schema update time verification to insert and upsert so as to use…
94bc70a 
… the cache

Signed-off-by: Xianhui.Lin <[email protected]>

fix unitest

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>

fix code

Signed-off-by: Xianhui.Lin <[email protected]>

fix test

Signed-off-by: Xianhui.Lin <[email protected]>

fix go test

Signed-off-by: Xianhui.Lin <[email protected]>

add go unitest

Signed-off-by: Xianhui.Lin <[email protected]>

fix unitest error

Signed-off-by: Xianhui.Lin <[email protected]>

fix ut

Signed-off-by: Xianhui.Lin <[email protected]>

improve

Signed-off-by: Xianhui.Lin <[email protected]>
@mergify mergify bot added ci-passed and removed ci-passed labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

@czs007 czs007 Awaiting requested review from czs007

Assignees
No one assigned
Labels
area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JsDove @sre-ci-robot