Skip to content

Conversation

@snurkabill
Copy link

it could be done for all network architectures. it's simple ... maybe dummy :)

@mihaelacr
Copy link
Owner

Hi! Thanks for the contribution!

Code looks good. I think that it might be more general though to do something similar to the 'activation functions' module, by adding a parameter to the DBN class that specifies the cost function to be used. This will allow to easily have different cost functions both for classification and regression.

What do you think? I would add a parameter cost_function to the DBN constructor and a cost_functions.py module which wraps over the theano functions, just like activation_functions does, using a similar API (cost(x,y)). Note that the wrappers are needed so that someone that does not know theano can use pydeeplearn.

@snurkabill
Copy link
Author

I agree, problem might be that I don't know anything about theano :) trying to code something right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants