Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct pointer comparison issue in MFRC522Extended.cpp #635

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

robosphere99
Copy link
Contributor

@robosphere99 robosphere99 commented Aug 16, 2024

  • Fixed an issue in MFRC522Extended.cpp where the code incorrectly compared a pointer (backLen) with an integer.
  • Modified the conditional statements at lines 824 and 847 to properly check if backLen is not null and its value is greater than zero.
  • This resolves compilation errors related to ordered comparison of pointers with integers in the MFRC522 library.
Q A
Bug fix? yes
New feature? no
Doc update? no
BC breaks? no
Deprecations? no
Fixed tickets edit(Rotzbua): maybe #371

- Fixed an issue in `MFRC522Extended.cpp` where the code incorrectly compared a pointer (`backLen`) with an integer.
- Modified the conditional statements at lines 824 and 847 to properly check if `backLen` is not null and its value is greater than zero.
- This resolves compilation errors related to ordered comparison of pointers with integers in the MFRC522 library.
@robosphere99
Copy link
Contributor Author

i have tested it with esp32 , it is working fine.
i am attaching the pic in which after successful compilation its gets uploaded...
Screenshot 2024-08-16 080447

@AndreaIannoli
Copy link

Tested with esp32 and works!

@Rotzbua Rotzbua merged commit 4ac9700 into miguelbalboa:master Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants