Piper #15
Merged
Piper #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPU support to be added. STDERR from Piper is suppressed for now.
Note, this is perhaps not the best way to indicate the current text format.
sveinbjornt
reviewed
Dec 6, 2024
sveinbjornt
reviewed
Dec 6, 2024
sveinbjornt
reviewed
Dec 6, 2024
sveinbjornt
reviewed
Dec 6, 2024
sveinbjornt
reviewed
Dec 6, 2024
sveinbjornt
reviewed
Dec 6, 2024
sveinbjornt
reviewed
Dec 6, 2024
sveinbjornt
reviewed
Dec 6, 2024
sveinbjornt
reviewed
Dec 6, 2024
Change class name so not to conflict with piper python bindings.
sveinbjornt
reviewed
Dec 11, 2024
sveinbjornt
reviewed
Dec 11, 2024
|
I suggest removing in tts.py, and making one of the Piper voices the default voice. That way, the package works out of the box without requiring an API key. |
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no suggestions.
Remove API key warning. Small piper fixes.
|
I'm looking into the dependency issues. It seems python 3.12 has problems with both Piper and OpenSSL 3.0.* required by Azure services. |
This is due to greynir terminal nodes being None and zip not being strict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Piper TTS and misc bug fixes.
The last commit, 13c84a0, needs some work.