This repository was archived by the owner on Sep 10, 2021. It is now read-only.
Only update producer definition if it differs from saved hash #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpatrick This does the hashing of the producer definition. You can use it as an example and work it into your refactoring. We may not want to merge it as is, or we can to roll it out sooner if you think your refactoring will take longer.
If we deploy this, all of the producer definitions that were saved as JSON blobs will get replaced by future pipeline submissions, i.e., we don't have to do anything to clean up the DB for
tracker_producer.producer_definition, it'll happen naturally.