Skip to content

Add dummy proof keys and discovery XML - #86

Open
Thomas Levesque (thomaslevesque) wants to merge 1 commit into
microsoft:mainfrom
thomaslevesque:wopi-proof
Open

Add dummy proof keys and discovery XML#86
Thomas Levesque (thomaslevesque) wants to merge 1 commit into
microsoft:mainfrom
thomaslevesque:wopi-proof

Conversation

@thomaslevesque

Copy link
Copy Markdown
Contributor

Fixes #22

Currently there's just a proof-keys.xml file with dummy keys, and a discovery.xml file with the corresponding public keys. In a future evolution, it might be useful to add an option to specify the proof keys file, but then the discover file would need to be updated to match the specified keys.

@tylerbutler

Copy link
Copy Markdown
Member

Thomas Levesque (@thomaslevesque) Thanks for the PR! Could you share the cert that you used and the process used to generate it?

@thomaslevesque

Copy link
Copy Markdown
Contributor Author

Hi Tyler Butler (@tylerbutler),

I didn't use a certificate, I just made a new RSACryptoServiceProvider and used ExportCspBlob(true) to get the private key and ExportCspBlob(false) to get the public key.
You can recreate the same keys from the proof-keys.xml file, using ImportCspBlob (which is what the code is doing)

@thomaslevesque

Thomas Levesque (thomaslevesque) commented Jan 24, 2020

Copy link
Copy Markdown
Contributor Author

and ExportCspBlob(false) to get the public key.

Actually, that's not quite right. This only gives the value for the public key in the discovery document. For the exponent and modulus, I used ExportParameters(false) and used the Exponent and Modulus properties of the result.

@thomaslevesque

Copy link
Copy Markdown
Contributor Author

If requested, I can add a small program to generate the keys (and maybe rotate them)

@petrsvihlik

Copy link
Copy Markdown

Longjia Niu (@niulongjia) / Rob Rolnick (@RobRol) — given the recent maintainer activity on this repo (#134 / #135 / #137 / #138) I figured it was worth another nudge here. The underlying gap (#22, deduped to #82 / #84 / #111) is still real and downstream hosts continue to work around it.

I've opened #145 which rebases this branch on current main. Single trivial conflict in Program.cs (main added TestGroupHasDelay to the GroupBy key since 2019); the proof-key / discovery XML payloads are unchanged. Full credit to Thomas Levesque (@thomaslevesque) for the original design — either PR works for me, whichever is easier to land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine the fate of the proof key tests

3 participants