Mitigate stack overflow issue#6224
Merged
Merged
Conversation
…choice to include message based on stack size in rethrow
yao-msft
previously approved these changes
May 12, 2026
yao-msft
reviewed
May 13, 2026
| ULONG_PTR low, high; | ||
| GetCurrentThreadStackLimits(&low, &high); | ||
| auto remaining = reinterpret_cast<ULONG_PTR>(&low) - low; | ||
| if (remaining > high - low) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (remaining > high - low) { | |
| if (remaining > high - low) | |
| { |
nit
yao-msft
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
We see some very rare crashes where the stack is too small to support the WIL message formatting of
THROW_HR_MSG. This change attempts to mitigate that through a few targeted reductions in stack usage (doesn't get a lot but these were the only high ROI locations found) and by probing the remaining stack to decide whether to include the exception message or not on the throw.🔗 References
None.
🔍 Validation
Manual run with forced error still includes the exception message.
Microsoft Reviewers: Open in CodeFlow