-
Notifications
You must be signed in to change notification settings - Fork 72
Add Bicep support #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bicep support #272
Conversation
Add initial setup Bicep
Hi @denelon. I already created an initial draft to add Bicep support. Even thought the I was curious to your thoughts, that's why I already opened it as draft. |
@denelon, I've submitted this for review since the PR has grown quite large. I've tried converting the I've done some initial local testing. Before diving into extensive testing (initial setup checks for linting only), I want to see if we can proceed with this. Some documentation has been added, though it might not be in the correct location. On the other side, after working on this for a while, I realize it might not belong in this repository. Maybe we can ask the AVM team to create a pattern for all three implementation performances. Let me know your thoughts. |
Eventually, I'd like to have this work lead into an Azure Marketplace offering. I'd want to keep that code here in this repository with some kind of "small", "medium", "large" concept to support different scale out scenarios. |
Cool, thanks for the reply Demitrius. I'll leave it up to the team to review :) |
Bicep will be transpiled to arm templates for deployment. This project already has arm templates well defined and we have custom logics in them. Also our PS module uses the arm templates for easy deployment. I don't feel we'll spend the resource to support an additional deployment method at the moment (meaning bicep deployment will work e2e without additional config, and smoke tests before every release). |
Thanks for the comment, Yao, and for taking it into consideration. Closing this one. |
This PR adds Bicep support to deploy a new WinGet Rest Source in Azure.