-
Notifications
You must be signed in to change notification settings - Fork 556
Replace unimplemented!
panics with conditional #[link]
attribute for WSL/Linux support
#1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,8 @@ default-target = "x86_64-pc-windows-msvc" | |
targets = [] | ||
|
||
[dependencies.windows-sys] | ||
version = "0.36.1" | ||
path = "../sys" | ||
version = "0.38" | ||
Comment on lines
+15
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kennykerr This will need your 👀. Probably can't be published like this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it has to be changed back before being published - the I've previously (in 4c7ae6b#r76875081) suggested to simply not bump the version of |
||
features = [ | ||
"Win32_System_SystemServices", | ||
"Win32_System_Diagnostics_Debug", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kennykerr I had to switch this back to make sure that
metadata
would use the updatedwindows-sys
crate without unconditional#[link]
, otherwise I wouldn't have been able to generate the changes in this PR (don't have quick access to a Windows machine to test/generate it otherwise).