Change default state of proposals exp#325322
Draft
alexr00 wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the extensionEnabledApiProposalsFallback experiment behavior used by isProposedApiEnabled in the extension host, changing how the fallback behaves on stable builds when the experiment assignment is missing vs empty.
Changes:
- Change
setEnabledApiProposalsFallbackExperiment(undefined, 'stable')to enable an “allow all fallback proposals” resolver (for extensions that declare at least one proposal). - Treat an empty string assignment (
'') as an explicit “block all fallback proposals” configuration. - Add unit tests covering the new default/empty behaviors.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/services/extensions/common/extensions.ts | Changes resolver semantics for the fallback experiment on stable builds, including new meaning for undefined vs ''. |
| src/vs/workbench/services/extensions/test/common/extensions.test.ts | Adds tests for “missing experiment” default behavior and for the explicit empty-string “block all” behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.