Record scheduled automation runs atomically#325294
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Moves schedule advancement into run claiming so run records and schedule metadata commit atomically.
Changes:
- Advances scheduled/catch-up timestamps during
recordRunStart. - Removes scheduler-side preemptive advancement.
- Adds regression coverage for claim and delayed-tick behavior.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/automations/automationService.ts |
Updates the service contract. |
src/vs/sessions/contrib/automations/browser/automationService.ts |
Atomically records claims and advances schedules. |
src/vs/sessions/contrib/automations/browser/automationScheduler.ts |
Removes pre-dispatch advancement. |
src/vs/sessions/contrib/automations/test/browser/automationService.test.ts |
Tests schedule advancement during claims. |
src/vs/sessions/contrib/automations/test/browser/automationScheduler.test.ts |
Tests claim-dependent reporting and scheduling. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Medium
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
sandy081
previously approved these changes
Jul 10, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hediet
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #325277
Validation
npm run typecheck-clientnpm run gulp compile-clientnpm run valid-layers-checkmerging; can revert if we don't like the fix
cc @benvillalobos