feat: Support modifier-click opening files and folders in a new window#325228
Open
cnyyc1024 wants to merge 1 commit into
Open
feat: Support modifier-click opening files and folders in a new window#325228cnyyc1024 wants to merge 1 commit into
cnyyc1024 wants to merge 1 commit into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @benibenjMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds modifier-click handling to open File-menu resources in a new window.
Changes:
- Detects platform-specific modifier clicks.
- Redirects supported open actions to existing new-window commands.
- Covers custom and native menubars.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
menubarControl.ts |
Handles modifier clicks in the custom menubar. |
menubar.ts |
Handles modifier clicks in the native menubar. |
Comment on lines
+393
to
+399
| switch (commandId) { | ||
| case 'workbench.action.files.openFileFolder': | ||
| return 'workbench.action.files.openFileFolderInNewWindow'; | ||
| case 'workbench.action.files.openFolder': | ||
| return 'workbench.action.files.openFolderInNewWindow'; | ||
| default: | ||
| return commandId; |
Comment on lines
+594
to
+600
| switch (commandId) { | ||
| case 'workbench.action.files.openFileFolder': | ||
| return 'workbench.action.files.openFileFolderInNewWindow'; | ||
| case 'workbench.action.files.openFolder': | ||
| return 'workbench.action.files.openFolderInNewWindow'; | ||
| default: | ||
| return commandId; |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325225
This adds modifier-click support for File menu open actions so users can open files and folders in a new window without adding new visible menu items.
The implementation reuses the existing
*InNewWindowcommands:workbench.action.files.openFileFolderInNewWindowworkbench.action.files.openFolderInNewWindowIt handles both menu paths:
How to test:
CtrlorShifton Windows/Linux.File > Open Folder....File > Open Folder...still opens with the existing behavior.On macOS, use
CmdorOptioninstead.Validation:
npm run typecheck-clientnpm run precommit