Skip to content

Add session provider picker to automations dialog#325223

Merged
benvillalobos merged 11 commits into
mainfrom
bv/automations-provider-picker
Jul 10, 2026
Merged

Add session provider picker to automations dialog#325223
benvillalobos merged 11 commits into
mainfrom
bv/automations-provider-picker

Conversation

@benvillalobos

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 10, 2026 01:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a session provider/type picker to the Automations dialog.

Changes:

  • Replaces the fixed Copilot CLI chip with SessionTypePicker.
  • Synchronizes the selected provider and session type into automation data.
  • Removes fixed provider/type defaults and the legacy binder.
Show a summary per file
File Description
automationDialog.ts Integrates and synchronizes the session type picker.
automationDialogService.ts Saves the picker’s provider and session type.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment thread src/vs/sessions/contrib/automations/browser/automationDialogService.ts Outdated
Comment thread src/vs/sessions/contrib/automations/browser/automationDialog.ts Outdated
Comment thread src/vs/sessions/contrib/automations/browser/automationDialog.ts Outdated
Comment thread src/vs/sessions/contrib/automations/browser/automationDialog.ts Outdated
benvillalobos and others added 6 commits July 10, 2026 07:44
The automation dialog was using the desktop-only SessionTypePicker
directly. The rest of the codebase uses MobileSessionTypePicker which
renders a bottom sheet on phone layouts and falls back to the desktop
action-widget popup otherwise. Swap to the mobile-aware subclass so
the automation picker behaves consistently on all viewports.
@benvillalobos benvillalobos marked this pull request as ready for review July 10, 2026 18:24
@benvillalobos benvillalobos enabled auto-merge (squash) July 10, 2026 18:25
@benvillalobos benvillalobos merged commit e8a3ead into main Jul 10, 2026
46 of 47 checks passed
@benvillalobos benvillalobos deleted the bv/automations-provider-picker branch July 10, 2026 19:51
@vs-code-engineering vs-code-engineering Bot added this to the 1.129.0 milestone Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants