Prevent duplicate model picker icons#325200
Merged
Merged
Conversation
Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix double icon display for models with warnings
Prevent duplicate model picker icons
Jul 9, 2026
Collaborator
|
@copilot we should actually prefer to show the warning icon always when there is grounds to show that icon |
Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>
Contributor
Author
justschen
approved these changes
Jul 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents duplicate icons in the chat model picker by selecting one icon based on precedence.
Changes:
- Adds centralized model-picker icon selection.
- Uses one icon in the selected-model label.
- Adds regression coverage.
Show a summary per file
| File | Description |
|---|---|
chatModelPicker.ts |
Implements icon precedence and removes duplicate rendering. |
chatModelPicker.test.ts |
Tests warning-icon selection. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>
justschen
approved these changes
Jul 10, 2026
benvillalobos
previously approved these changes
Jul 10, 2026
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
…on-issue # Conflicts: # src/vs/workbench/contrib/chat/test/browser/widget/input/chatModelPicker.test.ts Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>
Contributor
Author
roblourens
approved these changes
Jul 10, 2026
justschen
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models with warning status displayed both the provider and warning icons.