support data URI's in image preview#237222
Open
jogibear9988 wants to merge 3 commits intomicrosoft:mainfrom
Open
support data URI's in image preview#237222jogibear9988 wants to merge 3 commits intomicrosoft:mainfrom
jogibear9988 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
It works, but the URI is used as the filename: 
Is there a way to change this? I open via |
mjbvz
requested changes
Jan 9, 2025
|
|
||
| private async getResourcePath(webviewEditor: vscode.WebviewPanel, resource: vscode.Uri, version: string): Promise<string> { | ||
| if (resource.scheme === 'data') { | ||
| return decodeURIComponent(resource.toString()); |
Collaborator
There was a problem hiding this comment.
I don't think decoding should be needed. If it is, there's likely a bug somewhere else that needs to be fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support data URI's for image preview
fixes #237220