fix ls not respecting vsce options in manifest #1214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1213 (the
lspart, not the )changes:
anypatchOptionsWithManifestcall needed to makelsbehave correctlyAs it was very unclear what
patchOptionsWithManifestdid, so I scanned the source code to see where it is used and how. I found that only thepublishandpackage(lsas a sub command ofpackage) use thepatchOptionsWithManifestfunction. Therefore I defined the types to reflect that. It is a bit ugly, because typescript does not like it when you are dynamically patching objects, especially withreadonlyproperties, but I think its more accurate this way. I had to use 1 instance ofanybecause typescript refuses to believe the properties were assignable, but nothing is changed in runtime semantics asanywas used before the change.I tried to add a test, but found there is no existing test (suite) for including options as part of the
package.json, so was unsure where to add it. The related tests inpackage.test.tsfocuss on testing the implementations and bypasses reading the options from the manifest file.I tested it with: