forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Switch to queue based execution for executing Python code #25669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+165
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot read properties of undefined ('show') when running Python code
Cannot read properties of undefined ('show') when running Python code
eleanorjboyd
approved these changes
Dec 16, 2025
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Dec 16, 2025
…25669) Resolves: microsoft/vscode-python-environments#958 Challenge is that sendText would get called when terminal is not ready. And doing `undefined.show()` is the problem. Switching to queue based execution for running REPL commands, which would prevent from us losing the first command as well.
eleanorjboyd
added a commit
that referenced
this pull request
Dec 16, 2025
…25671) Resolves: microsoft/vscode-python-environments#958 Challenge is that sendText would get called when terminal is not ready. And doing `undefined.show()` is the problem. Switching to queue based execution for running REPL commands, which would prevent from us losing the first command as well. Co-authored-by: Anthony Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-terminal
bug
Issue identified by VS Code Team member as probable bug
important
Issue identified as high-priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: microsoft/vscode-python-environments#958
Challenge is that sendText would get called when terminal is not ready. And doing
undefined.show()is the problem.Switching to queue based execution for running REPL commands, which would prevent from us losing the first command as well.