Skip to content

Conversation

@anthonykim1
Copy link

@anthonykim1 anthonykim1 commented Dec 15, 2025

Resolves: microsoft/vscode-python-environments#958

Challenge is that sendText would get called when terminal is not ready. And doing undefined.show() is the problem.
Switching to queue based execution for running REPL commands, which would prevent from us losing the first command as well.

@anthonykim1 anthonykim1 added this to the December / January 2026 milestone Dec 15, 2025
@anthonykim1 anthonykim1 self-assigned this Dec 15, 2025
@anthonykim1 anthonykim1 changed the title Anthonykim1/prevent undefined show Prevent Cannot read properties of undefined ('show') when running Python code Dec 15, 2025
@anthonykim1 anthonykim1 marked this pull request as draft December 15, 2025 18:29
@anthonykim1 anthonykim1 added the bug Issue identified by VS Code Team member as probable bug label Dec 15, 2025
@anthonykim1 anthonykim1 added the important Issue identified as high-priority label Dec 16, 2025
@anthonykim1 anthonykim1 reopened this Dec 16, 2025
@anthonykim1 anthonykim1 marked this pull request as ready for review December 16, 2025 07:30
@anthonykim1 anthonykim1 marked this pull request as draft December 16, 2025 17:14
@anthonykim1 anthonykim1 changed the title Prevent Cannot read properties of undefined ('show') when running Python code Switch to queue based execution for executing Python code Dec 16, 2025
@anthonykim1 anthonykim1 marked this pull request as ready for review December 16, 2025 17:40
@anthonykim1 anthonykim1 enabled auto-merge (squash) December 16, 2025 17:40
@anthonykim1 anthonykim1 merged commit c7efb6e into main Dec 16, 2025
86 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/preventUndefinedShow branch December 16, 2025 17:55
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Dec 16, 2025
…25669)

Resolves:
microsoft/vscode-python-environments#958

Challenge is that sendText would get called when terminal is not ready.
And doing `undefined.show()` is the problem.
Switching to queue based execution for running REPL commands, which
would prevent from us losing the first command as well.
eleanorjboyd added a commit that referenced this pull request Dec 16, 2025
…25671)

Resolves:
microsoft/vscode-python-environments#958

Challenge is that sendText would get called when terminal is not ready.
And doing `undefined.show()` is the problem.
Switching to queue based execution for running REPL commands, which
would prevent from us losing the first command as well.

Co-authored-by: Anthony Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'show')

4 participants