Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures development mode ids are calculated from development path #97

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

karthiknadig
Copy link
Member

Fixes #96

@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Dec 18, 2024
@karthiknadig karthiknadig self-assigned this Dec 18, 2024
@karthiknadig karthiknadig changed the title Ensures development mode registration ids are calculated from development path Ensures development mode ids are calculated from development path Dec 18, 2024
@karthiknadig karthiknadig requested a review from Copilot December 18, 2024 20:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/common/utils/frameUtils.ts:52

  • [nitpick] The error message could be more descriptive. Suggestion: 'Unable to determine calling extension id. Registration failed due to missing or invalid extension path.'
throw new Error('Unable to determine calling extension id, registration failed');

src/api.ts Show resolved Hide resolved
@karthiknadig karthiknadig marked this pull request as ready for review December 18, 2024 20:44
@karthiknadig karthiknadig enabled auto-merge (squash) December 18, 2024 20:44
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Dec 18, 2024
@karthiknadig karthiknadig merged commit 6bc409d into microsoft:main Dec 18, 2024
6 checks passed
@karthiknadig karthiknadig deleted the id-bug1 branch December 22, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env Manager maps package manager name to vscode-python extension for preferredPackageManagerId
2 participants