Adapt to evaluating activate in core shell integration #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
commented
Aug 13, 2025
anthonykim1
commented
Aug 13, 2025
anthonykim1
commented
Aug 13, 2025
eleanorjboyd
previously approved these changes
Aug 14, 2025
eleanorjboyd
approved these changes
Aug 15, 2025
This was referenced Aug 15, 2025
anthonykim1
added a commit
that referenced
this pull request
Aug 15, 2025
Resolves: #726 Coming from #717 /cc @karthiknadig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue related: microsoft/vscode#259637
Adapting to: microsoft/vscode#261094
FYI if activation fails when eval from shell integration scripts, we're making it very obvious for them: microsoft/vscode#261094 (comment)
TODO: Remove activation debris in shell init files for existing users.
/cc @cwebster-99