Skip to content

Distinguish between direct and transitive packages#1530

Open
edvilme wants to merge 14 commits into
mainfrom
vscode-python-environments-package-transitive
Open

Distinguish between direct and transitive packages#1530
edvilme wants to merge 14 commits into
mainfrom
vscode-python-environments-package-transitive

Conversation

@edvilme

@edvilme edvilme commented May 20, 2026

Copy link
Copy Markdown
Contributor

This pull request attempts to identify transitive packages in the user environment, and show indicators in the UI.

Problem

image

All installed packages, regardless of hierarchy are displayed equally in the sidebar. However, the relationships between them is not entirely obvious through the UI. This may cause (less experienced) users to get confused when they see packages they haven't explicitly installed, or to modify/delete transitive packages, potentially affecting their direct packages.

Hence, there needs to be a way to clearly distinguish between them, and provide guardrails to prevent unintended behaviour.

Proposal

Direct packages are detected through the built in commands of the package managers

Package Manager Command Description
pip pip list --not-required --format=json Lists packages not required (direct, non-transitive) by other packages in a JSON format.
uv uv pip tree --depth 0 Lists a dependency tree of all the packages with depth 0 (i.e., doesn't include transitive packages).
poetry poetry show --top-level --no-ansi Lists the top level packages
conda conda env export --from-history * Lists explicitly installed packages (note: this does not differenciate between direct/transitive)

Packages shown are clearly identified as "Direct packages" or "Transitive" in the UI. Controls for uninstalling transitive packages are hidden to avoid unwanted behaviors.

image

Closes #524

@edvilme edvilme added the feature-request Request for new features or functionality label May 20, 2026
@edvilme edvilme requested a review from Copilot May 20, 2026 22:55

This comment was marked as resolved.

@eleanorjboyd

Copy link
Copy Markdown
Member

do you have a screenshot of what this would look like? and how do you see it working for other pkg managers?

@edvilme edvilme force-pushed the vscode-python-environments-package-transitive branch from 8f270b3 to 1bd1f7b Compare June 2, 2026 20:42
@edvilme edvilme changed the base branch from main to vscode-python-environments-package-refactor June 2, 2026 20:42
@edvilme

edvilme commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Depends on #1538
Will re-target and rebase when merged

@edvilme edvilme force-pushed the vscode-python-environments-package-transitive branch 2 times, most recently from 3eed7fb to e6467d6 Compare June 11, 2026 21:22
Base automatically changed from vscode-python-environments-package-refactor to main June 11, 2026 22:26
@edvilme edvilme force-pushed the vscode-python-environments-package-transitive branch from e6467d6 to 3f579f5 Compare June 11, 2026 22:44
edvilme and others added 2 commits June 11, 2026 15:47
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edvilme edvilme marked this pull request as ready for review June 11, 2026 22:57
@edvilme edvilme changed the title [Draft] Indicate transitive packages. Distinguish between direct and transitive packages Jun 11, 2026
@edvilme edvilme requested a review from Copilot June 12, 2026 00:00
Comment thread src/features/envCommands.ts Outdated
Comment thread src/managers/builtin/pipListUtils.ts
Comment thread src/managers/poetry/poetryPackageManager.ts
Comment thread src/api.ts
Comment thread src/test/managers/common/packageChanges.unit.test.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.

Comment thread src/managers/poetry/poetryPackageManager.ts
Comment thread src/managers/common/packageChanges.ts Outdated
Comment thread src/features/views/treeViewItems.ts Outdated
Comment thread src/features/views/treeViewItems.ts
Comment thread src/features/views/envManagersView.ts
Comment thread src/features/views/projectView.ts Outdated
Comment thread src/features/envCommands.ts
Comment thread src/api.ts
Comment thread api/src/main.ts
- Log parse failures in parsePipListJson() instead of silently returning []
- Make isTransitive readonly on PackageInfo and PythonPackageImpl
- Rename fetchDirectPackageNames to getDirectPackageNames in public API
- Fix JSDoc to say Set instead of array
- Add isTransitive to public API PackageInfo
- Localize transitive uninstall confirmation and (transitive) prefix
- Respect pkg.iconPath, only fallback to ThemeIcon
- Wrap getDirectPackageNames in try/catch for error isolation
- Use poetry show --top-level instead of --tree; fix glyph regex
- Only refresh packages when cache is empty, not on every expansion
- Add unit tests for parsePipListJson, parseUvTree, and error handling

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edvilme

edvilme commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Addressed all review comments in the latest commit. See individual replies on each comment thread for details.

Comment thread src/features/envCommands.ts
edvilme and others added 2 commits June 12, 2026 11:59
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear which packages were installed as dependencies of another

3 participants