-
Notifications
You must be signed in to change notification settings - Fork 19
Allow package manager to fully control install/uninstall steps #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 17 changed files in this pull request and generated 2 comments.
Files not reviewed (9)
- .vscode/settings.json: Language not supported
- examples/sample1/src/api.ts: Evaluated as low risk
- src/internal.api.ts: Evaluated as low risk
- src/common/localize.ts: Evaluated as low risk
- src/common/pickers/packages.ts: Evaluated as low risk
- src/api.ts: Evaluated as low risk
- src/managers/builtin/venvUtils.ts: Evaluated as low risk
- src/features/envCommands.ts: Evaluated as low risk
- src/managers/conda/condaPackageManager.ts: Evaluated as low risk
Comments suppressed due to low confidence (5)
src/managers/common/pickers.ts:21
- [nitpick] The
Installable
interface has bothname
anddisplayName
properties, which might be confusing. Consider renamingname
to something more specific, likeid
.
export interface Installable {
src/managers/builtin/pipManager.ts:52
- Ensure that the new behavior of prompting the user to select packages when none are provided is covered by tests.
async install(environment: PythonEnvironment, packages?: string[], options?: PackageInstallOptions): Promise<void> {
src/managers/builtin/pipManager.ts:91
- Ensure that the new behavior of prompting the user to select packages when none are provided is covered by tests.
async uninstall(environment: PythonEnvironment, packages?: Package[] | string[]): Promise<void> {
src/managers/conda/condaUtils.ts:26
- The
runConda
function should handle errors when parsing JSON and provide a clear error message if parsing fails.
return JSON.parse(raw);
src/managers/conda/condaUtils.ts:694
- [nitpick] Ensure that the
description
field is consistently used across the codebase and correctly populated in theselectFromCommonPackagesToInstall
function.
description: p.description,
@jjjermiah This should allow you to fully control the install/uninstall experience. I have removed the installable API. Instead, I directly call into the |
Closes #99