Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds group feature environment manager UI #101

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

karthiknadig
Copy link
Member

Closes #95

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Dec 22, 2024
@karthiknadig karthiknadig self-assigned this Dec 22, 2024
@jjjermiah
Copy link

@karthiknadig would it also be possible to add a contextValue for the group nodes? I think it would be valuable to execute commands on a group, i.e opening a manifest toml pertaining to that set of environments

@karthiknadig
Copy link
Member Author

karthiknadig commented Jan 6, 2025

@jjjermiah The context for the tree item should include the Group name and manager ID, like this pythonEnvGroup;ms-python.python:venv:mygroup;. You should be able to use that to set commands for specific groups.

@karthiknadig karthiknadig requested a review from Copilot January 6, 2025 19:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/api.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/features/views/envManagersView.ts:108

  • [nitpick] The variable name 'groupObjects' is ambiguous. It should be renamed to 'environmentGroups' for clarity.
const groupObjects: (string | EnvironmentGroupInfo)[] = [];

src/features/views/envManagersView.ts:128

  • Ensure that the new grouping behavior introduced by the 'PythonGroupEnvTreeItem' class is covered by tests.
if (element.kind === EnvTreeItemKind.environmentGroup) {
@karthiknadig karthiknadig marked this pull request as ready for review January 6, 2025 21:58
@karthiknadig karthiknadig enabled auto-merge (squash) January 6, 2025 21:59
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 6, 2025
@karthiknadig karthiknadig merged commit 5992c4d into microsoft:main Jan 6, 2025
6 checks passed
@karthiknadig karthiknadig deleted the group1 branch January 7, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for grouping environments
3 participants