This repository was archived by the owner on Dec 23, 2021. It is now read-only.
remove pillow version to rely on recommended - #377 #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on pillows default version for a given interpreter. 7 doesn't (easily) compile with Python 3.9, which blocks initialization of the extension. This is a bigger than expected issue as it can break/cause problems with ANY python workspace (ie not ones intended for use with Device Simulator) due to the default "always try to install requirements" extension setting.
julianrendell
requested review from
abmahdy,
adclements,
isadorasophia,
sagarmanchanda and
smmatte
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rely on pillows default version for a given interpreter. 7 doesn't (easily) compile with Python 3.9, which blocks initialization of the extension.
This is a bigger than expected issue as it can break/cause problems with ANY python workspace (ie not ones intended for use with Device Simulator) due to the default "always try to install requirements" extension setting.
This is related to #377 .
Type of change
Please delete options that are not relevant.
Testing:
Limited- MacOS 11.2.1, python 3.9.1 (via homebrew).