Update widget output params #5203
Conversation
| if (customMetadata.unconfined) { | ||
| metadata.unconfined = customMetadata.unconfined; | ||
| } | ||
| if ('mime' in request) { |
There was a problem hiding this comment.
Function looked the same as the function that I updated in renderers extension so same update here as well.
|
@DonJayamanne Is there a way to test this in stable as well? Can't just build and debug in stable as the stable engine isn't 1.55. With the renderers I copied over the client_renderer to the jupyter extension installed in stable to test. Can I just dump my out dir into the stable extension folder? I did check manualTestFiles (which has rich outputs + a few widgets) on insiders both with the old renderer code and my new updated renderer code and it looked legit to me. |
IanMatthewHuff
changed the title
When we create a new release, we'll pin against the next version of VS Code (which is the current insider). |
| data: { [mimeType: string]: any }; | ||
| metadata?: OldNotebookCellOutputMetadata; | ||
| } | ||
| interface OldNotebookOutputEventParams { |
There was a problem hiding this comment.
@IanMatthewHuff I think we can remove this code and there's no need for backwards compatiblity.
The only reason i wanted the backwards compatiblity for renderers, is so that it works with point releases of jupyter extension (point release is for current stable).
There was a problem hiding this comment.
@DonJayamanne Ahh, that's a good call. Wasn't thinking when I moved that code over. You are right, this will only release with matching stable builds. I'll remove that quick.
For #5195
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).