chore(deps-dev): bump glob from 7.2.3 to 13.0.6 - #1905
Conversation
919d9c3 to
46c360b
Compare
|
Dependabot (@dependabot) rebase |
f3d4a4c to
5caec3d
Compare
|
Dependabot (@dependabot) rebase |
383ce44 to
7b693ab
Compare
Bumps [glob](https://github.com/isaacs/node-glob) from 7.2.3 to 13.0.6. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v7.2.3...v13.0.6) --- updated-dependencies: - dependency-name: glob dependency-version: 13.0.6 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7b693ab to
f898181
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the glob 13 migration is scoped to dependency metadata and the required test-discovery API/order compatibility changes, with all checks passing.
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile still introduces glob@7.2.3 transitively (via rimraf@3), which remains deprecated/vulnerable and undercuts the security posture of the glob bump.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the dev dependency on glob to a new major version and adjusts the Mocha test entrypoints to use the newer promise-based/named-export API so test discovery continues to work under the upgraded glob.
Changes:
- Bump
globdevDependency from^7.2.3to^13.0.6. - Update test suite entrypoints to import
globas a named export andawaitthe promise API. - Regenerate lockfile to reflect new dependency graph for
glob@13.
File summaries
| File | Description |
|---|---|
| test/unmanaged-folder-suite/index.ts | Switches to glob named export + async/await-based file discovery. |
| test/suite/index.ts | Switches to glob named export + async/await-based file discovery. |
| package.json | Updates glob devDependency to ^13.0.6. |
| package-lock.json | Updates resolved dependency tree for glob@13 and related transitive deps. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the current head completes the glob 13 API and deterministic-order migration, replaces stale @types/glob with the directly used @types/minimatch, resolves the review thread, and has all checks passing.
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile still introduces glob@7.2.3 transitively (via rimraf@3), which is explicitly deprecated for security vulnerabilities and likely defeats the intent of the bump for security scanning.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the current head keeps the required test-discovery dependency, completes the glob 13 compatibility migration, and passes the full validation and CI gates.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the final head completes the glob 13 migration, declares the existing minimatch production import as a direct runtime dependency, and passes clean install, build, packaging, integration tests, and all CI checks.
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile still includes glob@7.2.3 via rimraf@3, which undermines the intent of bumping away from deprecated/vulnerable glob versions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the current head retains only directly required dependencies, completes the glob 13 compatibility migration, and has successful compile, lint, package, and CI results.
Bumps glob from 7.2.3 to 13.0.6.
Changelog
Sourced from glob's changelog.
... (truncated)
Commits
e80cb3813.0.69cdbbffrevert tsgo, not ready for test coverage correctness yet89c99bause tsgo compilerb7275d5update deps, expand engines to include node 18942e360update workflows, pull taprc out of package.json4a0d53cupdate tap for mockImport bugfixef94ad2update tap180c2d4update docs37993c8remove stray console.error in test03ae4c213.0.5Maintainer changes
This version was pushed to npm by isaacs, a new releaser for glob since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.