-
Notifications
You must be signed in to change notification settings - Fork 7
Fix NVDA screen reader grouping announcement for Query Insights controls #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: tnaum-ms <171359267+tnaum-ms@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes an accessibility issue where NVDA screen readers were not announcing the visual label "How would you rate Query Insights?" when users navigated to the like/dislike feedback buttons.
Changes:
- Wrapped feedback controls in a
<div role="group" aria-labelledby="...">to establish semantic association - Added
id="query-insights-rating-label"to the Text element for ARIA reference
|
@copilot apply the same solution to:
|
Co-authored-by: tnaum-ms <171359267+tnaum-ms@users.noreply.github.com>
Applied the accessibility grouping solution to all requested areas in commit 8d70fd7:
Screen readers will now announce the grouping labels when users navigate to these controls, providing the necessary context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
NVDA was not announcing visual labels when users navigated to related controls in the Query Insights tab, leaving screen reader users without context about what the controls were for.
Changes
Applied ARIA grouping pattern to multiple components in the Query Insights tab:
1. Feedback Card
<div role="group" aria-labelledby="query-insights-rating-label">id="query-insights-rating-label"to the Text element containing "How would you rate Query Insights?"2. Query Plan Summary
3. Performance Rating
Pattern Example:
Screen Reader Behavior
Before: Screen readers announced only the button/badge text without context
After: Screen readers now announce:
Screen readers now announce the group label when users navigate to controls, providing necessary context. Complies with WCAG 1.3.1 (Info and Relationships) and WCAG 4.1.2 (Name, Role, Value).
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.