Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 21, 2025

Addresses feedback on #398 regarding telemetry handling when multiple connection deletions fail.

Changes

  • Added comment explaining intentional capture of last error details when multiple deletions fail
  • Added errorCount metric to telemetry measurements to provide context on total failure count
// Note: When multiple deletions fail, we intentionally capture only the last error's
// details in telemetry. The errorCount metric below provides context on total failures.
context.telemetry.properties.error = 'RemoveConnectionError';
context.telemetry.properties.errorMessage = error instanceof Error ? error.message : String(error);

// ...after loop
context.telemetry.measurements.errorCount = failureCount;

The errorCount metric is a derived value but adds useful context alongside the existing connectionsToDelete and connectionsDeleted measurements.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix user connection removal functionality and add comments Add telemetry comment and errorCount metric for connection removal Nov 21, 2025
Copilot AI requested a review from tnaum-ms November 21, 2025 18:05
@tnaum-ms tnaum-ms marked this pull request as ready for review November 24, 2025 09:57
@tnaum-ms tnaum-ms requested a review from a team as a code owner November 24, 2025 09:57
@tnaum-ms tnaum-ms merged commit c6c2fed into dev/tnaum/connection-multi-delete Nov 24, 2025
1 check passed
@tnaum-ms tnaum-ms deleted the copilot/sub-pr-398 branch November 24, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants