Add support for Firefox preview #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed microsoft#16 Firefox only has preview support manifest v3 right now. To run this, follow the preview [instructions](https://extensionworkshop.com/documentation/develop/manifest-v3-migration-guide/) Firefox supports most the `chrome.*` API, so this adds checks for unsupported items However, Firefox does not currently support service workers nor Chromium support background pages. See [this for details](https://blog.mozilla.org/addons/2022/05/18/manifest-v3-in-firefox-recap-next-steps/) This means the manifest file will be incompatible with at least one browser ecosystem. Since stable Firefox doesn't support manifest v3 extensions anyway, I've just left that commented out. The other options end up with duplicated code Happy to try another approach and will file an issue to update this when stable Firefox supports manifest v3
joyceerhl
reviewed
Oct 17, 2022
The code is still shared between Chrome and Firefox Just the manifest differ
|
@joyceerhl the last change should make it good to go |
|
Firefox now has GA support for manifest V3 extensions, so this should be revisited |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #16
Firefox only has preview support manifest v3 right now. To run this, follow the preview instructions
Firefox supports most the
chrome.*API, so this adds checks for unsupported itemsHowever, Firefox does not currently support service workers nor Chromium support background pages. See this for details
This means the manifest file will be incompatible with at least one browser ecosystem. Since stable Firefox doesn't support manifest v3 extensions anyway, I've just left that commented out. The other options end up with duplicated code
Happy to try another approach and will file an issue to update this when stable Firefox supports manifest v3